DOC: Fixing notebook-style formatting on plot_segmentation_toy.py #23140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilke
reviewed
Apr 15, 2022
There was a problem hiding this comment.
Thank you for the PR!
Please let me know if there's anything I should revise and/or add.
In the spirit of your request, I have assembled a list of suggestions that I believe will dramatically improve the format of this example. Please review my suggestions and let me know what you think!
Improving clarity of the 4 circles example case Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
Improving clarity of the plotting code Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
Improving clarity and adding explanation to the two circles plotting case Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
RenTrieu
commented
Apr 16, 2022
jsilke
reviewed
Apr 16, 2022
There was a problem hiding this comment.
Thank you for considering my suggestions. I think what you have here already looks much better than the original example! There are only a couple more changes I would make to this notebook. Please review my followup comments when you have a chance and let me know what you think.
…updating plotting code
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
…t-learn#23140) Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
…t-learn#23140) Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Jordan Silke <51223540+jsilke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to issue #22406
What does this implement/fix? Explain your changes.
Fixes notebook style by replacing
# ####by block splitter# %%in plot_segmentation_toy.py.Any other comments?
Please let me know if there's anything I should revise and/or add.