DOC Fix duplicated module entries in whats_new #23060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Apr 6, 2022
|
I moved the entries to the right modules in my last commit |
jjerphan
approved these changes
Apr 6, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
|
Two approvals, merging my own PR! |
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the auto-merge functionality of whats_new files (xref #21516) is causing weird ordering of whats_new. Maybe this can happen without this auto-merge .gitattributes though.
This fixes it. I used this
git grepto track duplicated modules in whats_new. Output is on main and shows some duplicated module entries: