8000 DOC Small fixes in Tweedie deviances documentation by ctw · Pull Request #22952 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Small fixes in Tweedie deviances documentation #22952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2022

Conversation

ctw
Copy link
Contributor
@ctw ctw commented Mar 25, 2022

Fixed some typos / errors in Section 3.3.4.9. Mean Poisson, Gamma, and Tweedie deviances in the Model evaluation section of the user guide.

Fixed some typos / errors in Section 3.3.4.9. Mean Poisson, Gamma, and Tweedie deviances
2\left(\frac{\max(y_i,0)^{2-p}}{(1-p)(2-p)}-
\frac{y\,\hat{y}^{1-p}_i}{1-p}+\frac{\hat{y}^{2-p}_i}{2-p}\right),
\frac{y_i\,\hat{y}^{1-p}_i}{1-p}+\frac{\hat{y}^{2-p}_i}{2-p}\right),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\frac{y_i\,\hat{y}^{1-p}_i}{1-p}+\frac{\hat{y}^{2-p}_i}{2-p}\right),
\frac{y_i\,\hat{y}_i^{1-p}}{1-p}+\frac{\hat{y}_i^{2-p}}{2-p}\right),

Is simpler to read in the code, I guess.

@lorentzenchr
Copy link
Member

@ctw Thanks for this doc improvement.

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan changed the title [MRG] Small fixes in Tweedie deviances documentation DOC Small fixes in Tweedie deviances documentation Apr 23, 2022
@thomasjpfan thomasjpfan merged commit 8d295fb into scikit-learn:main Apr 23, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0