8000 DOC use notebook-style for plot_sparse_cov.py #22807
Conversation
|
Thanks for your PR, FYI I edited the title of your PR so that it contains the example filename. The reason for this is that we have a script that updates the #22406 automatically and relies on the example filename being in the PR title. |
|
@fkaren27 this PR would benefit from being synchronized with a more recent version of
then you should be able to do: # update your local main branch with the latest main from upstream
git checkout main
git pull upstream main
# synchronize you branch with the latest changes in main
git checkout example-plot-sparse-cov
git merge main
# update your PR (#22807) on GitHub
git push origin example-plot-sparse-cov |
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Those extra blank lines are not expected and make the linter step fail on the CI
You can make sure that your files are automatically formatted by running black on them:
pip install black==22.1.0
black examples/covariance/plot_sparse_cov.py
Instead of running the second line in the terminal, you can also format the code directly from VS Code using ctrl-shift-p + "Format document...".
There was a problem hiding this comment.
Thank you for the tips, I will correct this.
There was a problem hiding this comment.
Thanks @fkaren27. I think the rendering would be improved if the comments separating sections were titles
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
|
Merging, thanks a lot! |
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Reference Issues/PRs
#22406
This is a work in progress as part of the #pariswimlds sprint.