8000 DOC: use notebook-style for plot_feature_agglomeration_vs_univariate_selection.py by MarieSacksick · Pull Request #22796 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: use notebook-style for plot_feature_agglomeration_vs_univariate_selection.py #22796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2022
Merged

DOC: use notebook-style for plot_feature_agglomeration_vs_univariate_selection.py #22796

merged 1 commit into from
Mar 12, 2022

Conversation

MarieSacksick
Copy link
Contributor
@MarieSacksick MarieSacksick commented Mar 12, 2022 •
edited
Loading

…eration_vs_univariate_selection.py #22406

Reference Issues/PRs

Related to issue #22406

What does this implement/fix? Explain your changes.

Mainly breaking the cells in smaller elements, and adding a couple of comments.
To me, it seems that there was not much else to do.

Any other comments?

Pull request done in the context of the #pariswimlds sprint

GaelVaroquaux
GaelVaroquaux approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member
@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As this is a doc-only change, I will merge once the tests are green.

@GaelVaroquaux GaelVaroquaux merged commit 0fd4e4f into scikit-learn:main Mar 12, 2022
@lesteve lesteve changed the title chore(notebook_example): improve examples/cluster/plot_feature_agglom… DOC: use notebook-style for plot_feature_agglomeration_vs_univariate_selection.py Mar 14, 2022
@lesteve lesteve mentioned this pull request Mar 14, 2022
Closed
47 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@MarieSacksick @glemaitre
chore(notebook_example): improve examples/cluster/plot_feature_agglom…
4c0ad08 
…eration_vs_univariate_selection.py scikit-learn#22406 (scikit-learn#22796)

Co-authored-by: Marie <marie.sacksick@cybelangel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarieSacksick @GaelVaroquaux
0