DOC use notebook-style for plot_svm_anova.py #22779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, I edited the title of your PR so that it contains the exemple filename! One of the reason is that we have a script that updates #22406 automatically and that this script relies on the filename being in the PR title. |
adrinjalali
approved these changes
Mar 12, 2022
ogrisel
reviewed
Mar 13, 2022
examples/svm/plot_svm_anova.py
Outdated
| @@ -20,14 +20,14 @@ | |||
| from sklearn.svm import SVC | |||
There was a problem hiding this comment.
Could you please remove this cell and move the imports at the beginning of each cell below: each import should go to the cell it is first needed.
This would make the example nicer by avoiding the wall-of-import effect in the first cell.
ogrisel
reviewed
Mar 13, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
and move sections to titles.
|
Merging, thanks a lot! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#pariswimlds
Reference Issues/PRs
Issue in #22406
What does this implement/fix? Explain your changes.
Minor Doc fix : replacing
# ####by# %%Any other comments?