8000 MAINT Create a private extension for sorting utilities by jjerphan · Pull Request #22760 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Create a private extension for sorting utilities #22760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2022
Merged

MAINT Create a private extension for sorting utilities #22760

merged 3 commits into from
Mar 17, 2022

Conversation

jjerphan
Copy link
Member
@jjerphan jjerphan commented Mar 11, 2022 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Various sorting functions are present at various places within scikit-learn.

This PR proposes grouping them in a private submodule, paving the way to a centralised definition of low-level sorting routines relying on std::algorithm.

Any other comments?

Sorting algorithms from sklearn.tree._splitter.pyx will also be moved here.

CC @thomasjpfan

@jjerphan jjerphan mentioned this pull request Mar 11, 2022
Closed
@adam2392 adam2392 mentioned this pull request Mar 15, 2022
Draft
14 tasks
thomasjpfan
thomasjpfan reviewed Mar 16, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

8000
@jjerphan jjerphan marked this pull request as ready for review March 17, 2022 08:41
lorentzenchr
lorentzenchr approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomasjpfan
thomasjpfan approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 0b2f4ea into scikit-learn:main Mar 17, 2022
@jjerphan jjerphan deleted the simultaneous-sort-refactor branch March 18, 2022 09:05
@lorentzenchr lorentzenchr mentioned this pull request Mar 30, 2022
Open
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@jjerphan @glemaitre
MAINT Create a private extension for sorting utilities (scikit-learn#…
abade87 
…22760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
cython module:metrics module:neighbors module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjerphan @thomasjpfan @lorentzenchr
0