8000 DOC: Update notebook-style for example plot_image_denoising by AmarCodes-22 · Pull Request #22739 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: Update notebook-style for example plot_image_denoising #22739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2022
Merged

DOC: Update notebook-style for example plot_image_denoising #22739

merged 3 commits into from
Mar 17, 2022

Conversation

AmarCodes-22
Copy link
Contributor
@AmarCodes-22 AmarCodes-22 commented Mar 9, 2022 •
edited
Loading

Reference Issues/PRs

#22406

What does this implement/fix? Explain your changes.

Changed notebook-style example to use preferred # %% instead of the current long line of # ##

Any other comments?

  • Added headings where seemed fit.
  • Moved import statements to cells where they're first used

@AmarCodes-22 AmarCodes-22 changed the title Update notebook-style for example plot_image_denoising DOC: Update notebook-style for example plot_image_denoising Mar 9, 2022
@lesteve lesteve added the Quick Review For PRs that are quick to review label Mar 12, 2022
@lesteve lesteve mentioned this pull request Mar 12, 2022
Closed
47 tasks
ArturoAmorQ
ArturoAmorQ approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member
@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it is

jeremiedbb
jeremiedbb reviewed Mar 17, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of section is weird. the section # Display the distorted image should right after generate distorted image. Other than that, looks good

@AmarCodes-22 AmarCodes-22 requested a review from jeremiedbb March 17, 2022 12:35
jeremiedbb
jeremiedbb approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AmarCodes-22

@jeremiedbb jeremiedbb merged commit 5a9b2ce into scikit-learn:main Mar 17, 2022
@AmarCodes-22 AmarCodes-22 deleted the update-notebook-style-example-plot_image_denoising branch March 17, 2022 16:05
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@AmarCodes-22 @glemaitre
DOC Update notebook-style for example plot_image_denoising (scikit-le…
43b04b2 
…arn#22739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmarCodes-22 @jeremiedbb @ArturoAmorQ @lesteve
0