ENH Include entire range in check_scalar error message #22721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Mar 7, 2022
| f"{name} == {x}, must be" | ||
| f" {'<=' if include_boundaries in ('right', 'both') else '<'} {max_val}." | ||
| ) | ||
| raise ValueError(f"{name} == {x}, must be in the range {boundary}.") |
There was a problem hiding this comment.
Nit: I prefer to avoid creating the string if there is no error:
include_left = include_boundaries in ("left", "both")
include_right = include_boundaries in ("right", "both")
left_comparison_operator = operator.lt if include_left else operator.le
right_comparison_operator = operator.gt if include_right else operator.ge
if (min_val is not None and left_comparison_operator(x, min_val)) or (
max_val is not None and right_comparison_operator(x, max_val)
):
# Assume that inf boundaries are always open
left_bound = "[" if include_left and min_val is not None else "("
right_bound = "]" if include_right and max_val is not None else ")"
min_val_str = "-inf" if min_val is None else min_val
max_val_str = "inf" if max_val is None else max_val
range_str = f"{left_bound}{min_val_str}, {max_val_str}{right_bound}"
raise ValueError(f"{name} == {x}, must be in range {range_str}.")(Also to avoid the nested if statement in the current implementation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is a PR to address issue #22691 , where the entire boundary will be shown in the error message within
check_scalar.