DOC Fix notebook-style for plot_document_clustering.py #22443
Conversation
|
@gpapadok Thanks for the PR. This example is indeed really old. I think that it would benefit from a full rewriting by removing all options to use it as a script, rewrite it into smaller and easier code cells, and add the explanations next to the code cells then. Such rewriting would require more time. I propose to merge this PR first. @gpapadok would like to contribute a rewriting of the example? If not, we will add this example into a pool of examples that needs to be revamped. |
| @@ -134,8 +134,10 @@ def is_interactive(): | |||
| sys.exit(1) | |||
|
|
|||
|
|
|||
| # ############################################################################# | |||
| # %% | |||
There was a problem hiding this comment.
Looking at the rendering, I see that we always print the documentation if we are using the file as a script.
Could you edit the l.121 to not print it in interactive mode?
|
@glemaitre Edited as requested. I will update the example too and make a separate PR. |
|
Thanks @gpapadok. This is good to be merged as a first iteration. |
Reference Issues/PRs
For #22406
What does this implement/fix? Explain your changes.
Any other comments?