8000 DOC use notebook-style for example plot_feature_selection.py by NartayAikyn · Pull Request #22437 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC use notebook-style for example plot_feature_selection.py #22437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 14, 2022
Merged

DOC use notebook-style for example plot_feature_selection.py #22437

merged 10 commits into from
Feb 14, 2022

Conversation

NartayAikyn
Copy link
Contributor
@NartayAikyn NartayAikyn commented Feb 10, 2022 •
edited
Loading

Reference Issues/PRs

Part of #22406

What does this implement/fix? Explain your changes.

Changed example plot_prediction_latency.py to notebook-style.
To transform to the notebook style, I changed the order of some text, added some new text, and made minor changes to the code (mostly to change the position of the plot).

Any other comments?

I have two concerns, I hope these are ok:

  • With the above changes, the example becomes a bit longer.
  • Since I'm not a native speaker, I'm not sure about the coherence of the text.

Any ideas or suggestions are welcome!

NartayAikyn and others added 7 commits February 11, 2022 22:30
@NartayAikyn @glemaitre
Update examples/feature_selection/plot_feature_selection.py
7163c04 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@NartayAikyn @glemaitre
Update examples/feature_selection/plot_feature_selection.py
5c69dc6 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@NartayAikyn @glemaitre
Update examples/feature_selection/plot_feature_selection.py
4072b00 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@NartayAikyn @glemaitre
Update examples/feature_selection/plot_feature_selection.py
3236874 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@NartayAikyn @glemaitre
Update examples/feature_selection/plot_feature_selection.py
342b24b 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@NartayAikyn
Merge branch 'scikit-learn:main' into my_feature
c8528b1
@NartayAikyn
Update base on review
9cbfe44
@NartayAikyn
Copy link
Contributor Author

@glemaitre
Hi! Thanks for the suggestions, edited as requested.

@glemaitre
Copy link
Member

LGTM as a first iteration. We might improve the example in the future by adding more narrative.
Thanks @NartayXD

@glemaitre glemaitre merged commit 69dc086 into scikit-learn:main Feb 14, 2022
@lesteve lesteve mentioned this pull request Feb 15, 2022
Closed
47 tasks
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@NartayAikyn @glemaitre @thomasjpfan
DOC use notebook-style for example plot_feature_selection.py (scikit-…
9f1f645 
…learn#22437)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NartayAikyn @glemaitre
0