MNT Bump joblib version dependency to 1.0.0 #22365
Conversation
| memory = check_memory(None) | ||
| assert memory.cachedir is None | ||
| if joblib_before_0_12: |
There was a problem hiding this comment.
Might be a good time to upgrade minimal required joblib, particularly if we are not testing it? Currently, it's 0.11 released in 2017 which is a long time ago.
There was a problem hiding this comment.
We only test the minimum version of joblib in the ubuntu_altas job and coverage is turned off there.
I'm okay with bumping up the version. Do we go straight to joblib 1.1 or go to 0.12.5?
There was a problem hiding this comment.
Not sure. There were some known issues in the first few releases when joblib included loki around 0.12, maybe we can just go with 1.0 directly (late 2020)?
@ogrisel any opinion on this?
There was a problem hiding this comment.
Updated PR to bump joblib dependency to 1.0.0, which also lead to deleting a bunch of code.
| memory = check_memory("cache_directory") | ||
| assert memory.cachedir == os.path.join("cache_directory", "joblib") | ||
| if joblib_before_0_12: | ||
| assert memory.cachedir == os.path.join("cache_directory", "joblib") |
There was a problem hiding this comment.
We only test the minimum version of joblib in the ubuntu_altas job and coverage is turned off there.
|
This is really nice |
Is there any chocolate involved? :) |
sklearn requires 1.0 or above scikit-learn/scikit-learn#22365
sklearn requires 1.0 or above scikit-learn/scikit-learn#22365
sklearn requires 1.0 or above scikit-learn/scikit-learn#22365
Reference Issues/PRs
Fixes #22364
What does this implement/fix? Explain your changes.
cachedirwas removed in joblib/joblib#1236 so we can not directly test it intest_check_memory.