[MRG] MAINT Use check_scalar in _BaseVoting #22204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae4698c.
genvalen
commented
Jan 14, 2022
ogrisel
approved these changes
Jan 24, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
Hi @ogrisel! I believe this one is ready for merge. Unnecessary checks have been removed. |
|
The last failure was addressed in |
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20724 and #21927
#DataUmbrella
What does this implement/fix? Explain your changes.
Summary of changes to
votingestimators:_BaseVoting,VotingClassifier, andVotingRegressor.check_scalarfromsklearn.utilsto validate the parameters.Test and validation progress:
In both estimators
In VotingClassifier
References
Any other comments?
Please advise correct type/range if different than what I have below. (Thank you):
param: type-> range
n_jobs: int-> (-inf, -1] or [1, int), or None (not including 0)verbose: int-> [0, inf), or np.bool_flatten_transform: int-> (-inf, inf), or np.bool_