10000 ENH Preserving dtype for np.float32 in SparsePCA and MiniBatchSparsePCA by takoika · Pull Request #22111 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Preserving dtype for np.float32 in SparsePCA and MiniBatchSparsePCA #22111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 4, 2022
Merged

ENH Preserving dtype for np.float32 in SparsePCA and MiniBatchSparsePCA #22111

merged 14 commits into from
Jan 4, 2022
+56 −0

Conversation

takoika
Copy link
Contributor
@takoika takoika commented Jan 1, 2022

Reference Issues/PRs

This PR is part of #11000 .

What does this implement/fix? Explain your changes.

This MR confirms that SparsePCA and MiniBatchSparsePCA transformers preserve numpy.float32. Due to #22002 sparse PCA come to preserve numpy.float32. So tests to confirm preserving numpy.float32 are added.

Any other comments?

I used #20155 as references to make this.

ogrisel
ogrisel approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor suggestions:

jjerphan
jjerphan reviewed Jan 4, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @takoika.
This LGTM after addressing comments from @ogrisel's reviewl and this review.

@takoika takoika requested a review from jjerphan January 4, 2022 15:06
jjerphan
jjerphan reviewed Jan 4, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last sole comment.

@takoika takoika requested a review from jjerphan January 4, 2022 16:05
jjerphan
jjerphan approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @takoika.

@jjerphan jjerphan merged commit cb4688a into scikit-learn:main Jan 4, 2022
@thomasjpfan thomasjpfan mentioned this pull request Jan 8, 2022
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
module:decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takoika @ogrisel @jjerphan
0