8000 FIX Fixes plot_tree from going out of bounds by thomasjpfan · Pull Request #21917 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX Fixes plot_tree from going out of bounds #21917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 8, 2021
Merged

FIX Fixes plot_tree from going out of bounds #21917

merged 6 commits into from
Dec 8, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #21908

What does this implement/fix? Explain your changes.

Changes the coordination system to use xycoords="axes fraction". This means all the xy coords are between (0.0, 1.0), which I think is easier to reason about.

@thomasjpfan thomasjpfan mentioned this pull request Dec 8, 2021
Closed
ogrisel
ogrisel approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small refactoring of the example to use the notebook style and make the phrasing more explicit in the title of the 2D decision surface plots.

The rendering looks good locally. No cropping issue with the latest matplotlib (3.5.0).

@thomasjpfan thomasjpfan added this to the 1.0.2 milestone Dec 8, 2021
@lorentzenchr
Copy link
Member

The link of "ci/circleci: doc artifact" gives Artifact not found. Do we know why?

@ogrisel
Copy link
Member
ogrisel commented Dec 8, 2021

The link of "ci/circleci: doc artifact" gives Artifact not found. Do we know why?

That's new. It worked recently on other PRs...

@ogrisel
Copy link
Member
ogrisel commented Dec 8, 2021 •
edited
Loading

The circle ci artifacts have been updated successfully in the doc circle ci build:

https://158-135866406-gh.circle-artifacts.com/0/doc/_changed.html

but the direct link to circle ci artifact in the github report is https://158-843222-gh.circle-artifacts.com/0/doc/_changed.html which is a 404.

@lesteve
Copy link
Member
lesteve commented Dec 8, 2021

but the direct link to circle ci artifact in the github report is https://158-843222-gh.circle-artifacts.com/0/doc/_changed.html which is a 404.

For some reason the artifact link points to the previous commit build artifact (the previous commit build had a failure so no artifact can be found). Maybe just a temporary glitch? 🤞

lorentzenchr
lorentzenchr approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

8000
@lorentzenchr lorentzenchr merged commit 77fbdd1 into scikit-learn:main Dec 8, 2021
@lesteve
Copy link
Member
lesteve commented Dec 8, 2021

Thanks @thomasjpfan!

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@thomasjpfan @glemaitre
FIX Fixes plot_tree from going out of bounds (scikit-learn#21917)
abe2e07
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
@thomasjpfan @glemaitre
FIX Fixes plot_tree from going out of bounds (#21917)
126d846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot_tree diagram is cropped in iris example
4 participants
@thomasjpfan @lorentzenchr @ogrisel @lesteve
0