10000 DOC Accelerate plot_missing_values.py example by hansinahuja · Pull Request #21792 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Accelerate plot_missing_values.py example #21792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2022
Merged

DOC Accelerate plot_missing_values.py example #21792

merged 4 commits into from
May 3, 2022

Conversation

hansinahuja
Copy link
Contributor

Reference Issues/PRs

References #21598
Accelerates ../examples/impute/plot_missing_values.py

What does this implement/fix? Explain your changes.

The IterativeImputer was the main bottleneck which took ~13s. Decreased n_nearest_features and max_iters without any meaningful drop in performance. Other changes include decreasing the size of both the datasets, etc. to get it down to <15s.

Time taken decreased from ~28s to ~14s on my machine.

Output before the changes:
before

And after the changes:
after

Any other comments?

@adrinjalali adrinjalali mentioned this pull request Nov 29, 2021
Closed
41 tasks
@glemaitre glemaitre changed the title Accelerate plot_missing_values.py DOC Accelerate plot_missing_values.py example May 3, 2022
@glemaitre
Copy link
Member

I think that it will be good enough. We should revisit anyway this example as part of #21967

@glemaitre glemaitre merged commit eb309c4 into scikit-learn:main May 3, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request May 19, 2022
@hansinahuja @adrinjalali @glemaitre
DOC Accelerate plot_missing_values.py example (scikit-learn#21792)
60c0933 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request May 19, 2022
@hansinahuja @adrinjalali @glemaitre
DOC Accelerate plot_missing_values.py example (#21792)
829d9c6 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansinahuja @glemaitre @adrinjalali
0