MAINT Use Python 3.9 for Circle CI job 'doc' #21744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceback (most recent call last):
File "/home/circleci/miniconda/envs/testenv/bin/sphinx-build", line 6, in <module>
from sphinx.cmd.build import main
File "/home/circleci/miniconda/envs/testenv/lib/python3.10/site-packages/sphinx/cmd/build.py", line 25, in <module>
from sphinx.application import Sphinx
File "/home/circleci/miniconda/envs/testenv/lib/python3.10/site-packages/sphinx/application.py", line 31, in <module>
from sphinx.config import Config
File "/home/circleci/miniconda/envs/testenv/lib/python3.10/site-packages/sphinx/config.py", line 21, in <module>
from sphinx.util import logging
File "/home/circleci/miniconda/envs/testenv/lib/python3.10/site-packages/sphinx/util/__init__.py", line 41, in <module>
from sphinx.util.typing import PathMatcher
File "/home/circleci/miniconda/envs/testenv/lib/python3.10/site-packages/sphinx/util/typing.py", line 37, in <module>
from types import Union as types_Union
ImportError: cannot import name 'Union' from 'types' (/home/circleci/miniconda/envs/testenv/lib/python3.10/types.py)
make: *** [Makefile:53: html-noplot] Error 1It looks like a bug in sphinx that is not yet 100% ready for Python 3.10. |
ogrisel
approved these changes
Nov 22, 2021
|
The circle ci builds are all green. Feel free to make "read for review" / merge @jjerphan. |
adrinjalali
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
I think it does make sense to ping this here actually, thanks @jjerphan
|
We should have a document where we list the things we need to do to add support for a newly released python. Changing this is now one of them. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Several PRs, e.g. #18139 and #21341
What does this implement/fix? Explain your changes.
The
docjob sometimes fails on Circle CI (e.g https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/20372/workflows/ea9b8ea7-3a40-4987-bdab-03e90512e8f2/jobs/163634?invite=true#step-105-2111, e.g. https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/20310/workflows/25087498-3650-41fe-95c9-1a84de0af8e1/jobs/163379)It seems that this is due to some problems on Python 3.10.
The minor version of Python 3 to use is not specified.
This PR proposes pinning the version of Python 3 to use to 3.9 for Circle CI, solving those problems.