More informative error message when set_params has invalid values #21542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Nov 3, 2021
Comment on lines
+48
to
+51
| - |Enhancement| All scikit-learn models now generate a more informative | ||
| error message when setting invalid hyper-parameters with `set_params`. | ||
| :pr:`21542` by :user:`Olivier Grisel <ogrisel>`. | ||
|
|
There was a problem hiding this comment.
I would rather only put bugfixes in bugfix releases.
There was a problem hiding this comment.
No problem :D
Suggested change
| - |Enhancement| All scikit-learn models now generate a more informative | |
| error message when setting invalid hyper-parameters with `set_params`. | |
| :pr:`21542` by :user:`Olivier Grisel <ogrisel>`. | |
| - |Fix| All scikit-learn models now generate a more informative | |
| error message when setting invalid hyper-parameters with `set_params`. | |
| :pr:`21542` by :user:`Olivier Grisel <ogrisel>`. | |
There was a problem hiding this comment.
Jst kidding. I'm ok with that :)
jjerphan
reviewed
Nov 3, 2021
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…ikit-learn#21542) * More informative error message when set_params has invalid values * Update changelog * Typo [ci skip] Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Typo [ci skip] Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> * Simpler, more efficient code Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…ikit-learn#21542) * More informative error message when set_params has invalid values * Update changelog * Typo [ci skip] Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> * Typo [ci skip] Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> * Simpler, more efficient code Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the message more informative by listing the valid parameters names at the relevant nesting level when calling
set_paramswith invalid parameter names.See the updated pipeline/meta-estimator tests for examples on how the message is more informative.