ENH Add get_feature_names_out for random_projection module #21330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
ogrisel
approved these changes
Oct 20, 2021
144e1c0 to
e5766ef
Compare
lesteve
commented
Nov 2, 2021
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| all_SparseRandomProjection: List[Any] = [SparseRandomProjection] | |||
| all_DenseRandomProjection: List[Any] = [GaussianRandomProjection] | |||
| all_RandomProjection = set(all_SparseRandomProjection + all_DenseRandomProjection) | |||
| all_RandomProjection = all_SparseRandomProjection + all_DenseRandomProjection | |||
There was a problem hiding this comment.
This was done to avoid a pytest-xdist error about workers collecting different tests (different order).
It does not seem that crucial that all_RandomProjection is a set in this file.
|
Merged! Thanks @lesteve. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Part of #21308.
What does this implement/fix? Explain your changes.
Adds
get_feature_names_outto therandom_projectionmodule.Any other comments?
When #21079 gets merged, I could use
generate_names=Falsein_check_feature_names_in(see https://github.com/scikit-learn/scikit-learn/pull/21079/files#diff-962bea3f949b0a1e7b2ad40d2879f5d7ba1e6cd7da168daa82f84a87e800715e for more details) since the names of the output features don't reuse the names of the input features.