DOC Remove some str/unicode leftovers from Python 2#21270
Merged
rth merged 5 commits intoscikit-learn:mainfrom Oct 8, 2021
Merged
DOC Remove some str/unicode leftovers from Python 2#21270rth merged 5 commits intoscikit-learn:mainfrom
rth merged 5 commits intoscikit-learn:mainfrom
Conversation
* string → str (when meant as Python 2 `str` or `unicode` and not `bytes`) * unicode → str and str → bytes (when meant as Python 2 types) * str → bytes or str (when primarily meant for `bytes` and no-op for `str`)
a2c511e to
8b16f5c
Compare
ogrisel
approved these changes
Oct 7, 2021
Member
There was a problem hiding this comment.
LGTM, thanks for the clean-up!
thomasjpfan
reviewed
Oct 7, 2021
Member
There was a problem hiding this comment.
Thank you for the PR @DimitriPapadopoulos !
Most comments are to be consistent with other docstrings.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
jjerphan
approved these changes
Oct 8, 2021
Member
There was a problem hiding this comment.
LGTM, thank you @DimitriPapadopoulos for making those doc-strings uniform.
Member
|
Thanks @DimitriPapadopoulos! |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Oct 8, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Oct 25, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string→str(when meant as Python 2strorunicodeand notbytes)unicode→strandstr→bytes(when meant as Python 2 types)str→bytes or str(when primarily meant forbytesand no-op forstr)