8000 DOC Clarify use_idf by hongshaoyang · Pull Request #21213 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Clarify use_idf #21213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

DOC Clarify use_idf #21213

merged 1 commit into from
Oct 7, 2021

Conversation

hongshaoyang
Copy link
Contributor

Reference Issues/PRs

Closes #20553

What does this implement/fix? Explain your changes.

Clarify usage of use_idf parameter in TfidfTransformer and TfidfVectorizer.

Any other comments?

thomasjpfan
thomasjpfan approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @hongguangguo !

I think this is a net improvement. LGTM

@thomasjpfan thomasjpfan changed the title Clarify use_idf DOC Clarify use_idf Oct 1, 2021
@thomasjpfan thomasjpfan added this to the 1.0.1 milestone Oct 1, 2021
@thomasjpfan
Copy link
Member

Placing on 1.0.1 so the documentation gets updated with the next bug fix.

jjerphan
jjerphan approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member
@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @hongshaoyang.

@ogrisel ogrisel merged commit 8ad7c3f into scikit-learn:main Oct 7, 2021
@hongshaoyang hongshaoyang deleted the 20553 branch October 8, 2021 00:18
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Oct 8, 2021
@hongshaoyang @jjerphan
DOC Clarify use_idf in TfidfTransformer/TfidfVectorizer docstrings (s…
39fd93f 
…cikit-learn#21213)
@glemaitre glemaitre mentioned this pull request Oct 23, 2021
Merged
10 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 23, 2021
@hongshaoyang @glemaitre
DOC Clarify use_idf in TfidfTransformer/TfidfVectorizer docstrings (s…
4b1518d 
…cikit-learn#21213)
glemaitre pushed a commit that referenced this pull request Oct 25, 2021
@hongshaoyang @glemaitre
DOC Clarify use_idf in TfidfTransformer/TfidfVectorizer docstrings (#…
3637013 
…21213)
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@hongshaoyang @samronsin
DOC Clarify use_idf in TfidfTransformer/TfidfVectorizer docstrings (s…
174903b 
…cikit-learn#21213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Documentation module:feature_extraction
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

use_idf parameter in TfidfTransformer is confusing
4 participants
@hongshaoyang @thomasjpfan @ogrisel @jjerphan
0