8000 DOC Ensures that PowerTransformer passes numpydoc validation by jmloyola · Pull Request #21015 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Ensures that PowerTransformer passes numpydoc validation #21015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2021
Merged

DOC Ensures that PowerTransformer passes numpydoc validation #21015

merged 3 commits into from
Sep 13, 2021

Conversation

jmloyola
Copy link
Member

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures PowerTransformer is compatible with numpydoc.

  • Remove PowerTransformer from DOCSTRING_IGNORE_LIST.
  • Verify that all tests are passing.

glemaitre
glemaitre approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@jmloyola @glemaitre
Apply suggestions from code review
539bb48 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre glemaitre merged commit 597df0a into scikit-learn:main Sep 13, 2021
@glemaitre
Copy link
Member

All good Thanks @jmloyola

@jmloyola jmloyola deleted the fix_numpydoc_powertransformer branch September 13, 2021 15:54
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
@jmloyola @glemaitre @adrinjalali
DOC Ensures that PowerTransformer passes numpydoc validation (scikit-…
5d8804d 
…learn#21015)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
adrinjalali pushed a commit that referenced this pull request Sep 23, 2021
@jmloyola @glemaitre @adrinjalali
DOC Ensures that PowerTransformer passes numpydoc validation (#21015)
b9b7de4 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@jmloyola @glemaitre @samronsin
DOC Ensures that PowerTransformer passes numpydoc validation (scikit-…
b0ea5ba 
…learn#21015)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmloyola @glemaitre
0