8000 CI Migrates pypy3 test to Azure by thomasjpfan · Pull Request #21005 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@thomasjpfan
Copy link
Member

Reference Issues/PRs

Fixes #20995

What does this implement/fix? Explain your changes.

This PR:

  1. Moves pypy testing from circleci to azure.
  2. Extends posix-32.yml to run on any docker container with some adjustments for mamba and pypy.

Any other comments?

Note this PR disables pandas, because I ran into this strange error with pandas installed. We can look into the error in a follow up PR.

@thomasjpfan thomasjpfan changed the title MAINT Migrates pypy3 test to Azure CI Migrates pypy3 test to Azure Sep 10, 2021
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasjpfan LGTM

Copy link
Member
@alfaro96 alfaro96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thomasjpfan!

Just a question, when is the pypy3 job supposed to be run?

@ogrisel
Copy link
Member
ogrisel commented Sep 10, 2021

Just a question, when is the pypy3 job supposed to be run?

It used to be a nightly build, now it runs in all push events (PR or main branch). It takes 33min to run so it's longer than the other builds but there is another windows build that takes 30 min already.

Maybe this is fine. If it proves to slow, we can always update the config to run it in a schedule task + a manual commit msg trigger in PRs.

@ogrisel ogrisel merged commit 517b38a into scikit-learn:main Sep 10, 2021
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
adrinjalali pushed a commit that referenced this pull request Sep 23, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PyPy to tests on PRs

4 participants

0