8000 DOC Adds missing whats new in 1.0 by thomasjpfan · Pull Request #20938 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Adds missing whats new in 1.0 #20938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2021
Merged

DOC Adds missing whats new in 1.0 #20938

merged 2 commits into from
Sep 5, 2021

Conversation

thomasjpfan
Copy link
Member

Towards #20925

@thomasjpfan thomasjpfan added this to the 1.0 milestone Sep 4, 2021
lorentzenchr
lorentzenchr approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adrinjalali
adrinjalali reviewed Sep 5, 2021
View reviewed changes
doc/whats_new/v1.0.rst Outdated
@@ -378,6 +381,11 @@ Changelog
got overwritten during `fit`.
:pr:`20534` by :user:`Guillaume Lemaitre <glemaitre>`.

- |API| Removes `tol=None` option in
:class:`ensemble.HistGradientBoostingClassifier` and
:class:`ensemble.HistGradientBoostingRegressor`. Use `tol=0` for behavior.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for which behavior?

@adrinjalali adrinjalali merged commit cb72713 into scikit-learn:main Sep 5, 2021
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Sep 6, 2021
@thomasjpfan @adrinjalali
DOC Adds missing whats new in 1.0 (scikit-learn#20938)
d169a99 
* DOC Adds missing whats new in 1.0

* DOC Fixs wording
adrinjalali pushed a commit that referenced this pull request Sep 6, 2021
@thomasjpfan @adrinjalali
DOC Adds missing whats new in 1.0 (#20938)
f1eae42 
* DOC Adds missing whats new in 1.0

* DOC Fixs wording
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@thomasjpfan @samronsin
DOC Adds missing whats new in 1.0 (scikit-learn#20938)
4b99ba6 
* DOC Adds missing whats new in 1.0

* DOC Fixs wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @adrinjalali @lorentzenchr
0