Add what's new for 20200 for 1.0 #20927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Sep 3, 2021
doc/whats_new/v1.0.rst
Outdated
Comment on lines
221
to
222
| - |Fix| Fixed a bug in :class:`cluster.KMeans` preventing reproducibility even with a | ||
| fixed ``random_state``. :pr:`20200` by :user:`Jérémie du Boisberranger <jeremiedbb>`. |
There was a problem hiding this comment.
Suggested change
| - |Fix| Fixed a bug in :class:`cluster.KMeans` preventing reproducibility even with a | |
| fixed ``random_state``. :pr:`20200` by :user:`Jérémie du Boisberranger <jeremiedbb>`. | |
| - |Fix| Fixed a bug in :class:`cluster.KMeans` ensuring reproducibility even with an | |
| int ``random_state``. :pr:`20200` by :user:`Jérémie du Boisberranger <jeremiedbb>`. |
does it work with random states other than int?
|
There was a slight chance to get different results when calling KMeans with a same random_state (int or object at the same state), and when calling on dense and sparse input. I changed the description to be clearer (I hope :)). |
adrinjalali
approved these changes
Sep 3, 2021
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Sep 3, 2021
* add what's new for 20200 * clearer descr
adrinjalali
pushed a commit
that referenced
this pull request
Sep 6, 2021
* add what's new for 20200 * clearer descr
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
* add what's new for 20200 * clearer descr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adrinjalali This pr adds the missing what's new entry for 20200
related to #20925