8000 Check feature_names_in_ for sklearn.model_selection by ogrisel · Pull Request #20850 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Check feature_names_in_ for sklearn.model_selection #20850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2021
Merged

Check feature_names_in_ for sklearn.model_selection #20850

merged 5 commits into from
Aug 26, 2021

Conversation

ogrisel
Copy link
Member
@ogrisel ogrisel commented Aug 26, 2021

Reference Issues/PRs

Follow up to #18010

What does this implement/fix? Explain your changes.

Always delegate to the underlying best_estimator_ when defined. Depends on the value of refit in a complex way.

lorentzenchr
lorentzenchr approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a wish for unnitpicking.

thomasjpfan
thomasjpfan approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment otherwise LGTM

@ogrisel ogrisel merged commit 2a6426f into scikit-learn:main Aug 26, 2021
@ogrisel ogrisel deleted the feature_names_in_-model_selection branch August 26, 2021 20:58
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@ogrisel @thomasjpfan @samronsin
Check feature_names_in_ for sklearn.model_selection (scikit-learn#20850)
45c4f3a 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:model_selection No Changelog Needed Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @thomasjpfan @lorentzenchr
0