WIP support future extensiblity of grid search results #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Work with result dicts rather than tuples from fitting each fold * Refactor grid_search and cross_validation.cross_val_score
Closed
1 task
|
I note that result extensibility is still missing, but the refactoring that featured in this PR has been made redundant by @AlexanderFabisch's contributions. I'm closing this PR as it can't be easily rebased, and making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_searchandcross_validation.cross_val_scoreinto aCVScorer, which I think should be private for this release until we're happy with its interface.This will make it much easier to support returning training times, etc. and additional input such as
sample_weight.One of the main problem with dicts is that, unlike attributes of objects, the field names are difficult to deprecate (though if we needed to, we might consider subclassing dict).
It is part of the way towards a more extensible results interface from the
*SearchCVestimators, as discussed at the ML, #1787, #1768, and to some extent #1034, #1020.Note: the
CVScorerintroduced in this PR is missing tests as yet.