-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MAINT Adds sphinx configuration for redirections #20625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it does what we would like :)
LGTM
Great! Solution! Let's check that it renders well and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this works but it works great!
doc/templates/redirects.html
Outdated
<title>scikit-learn: machine learning in Python</title> | ||
</head> | ||
<body> | ||
<p>You will be automatically redirected to the <a href="{{ pathto('index') }}">main page</a>.</p> | ||
<p>You will be automatically redirected to the <a href="{{ redirect }}">main page</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>You will be automatically redirected to the <a href="{{ redirect }}">main page</a>.</p> | |
<p>You will be automatically redirected to the <a href="{{ redirect }}">new location of this page</a>.</p> |
Nice. Thanks @thomasjpfan |
Reference Issues/PRs
Follow up to #20624
What does this implement/fix? Explain your changes.
With #20624 we have an empty example:
This PR adds a mechanism for doing any redirect in sphinx.
Any other comments?
CC @glemaitre @ogrisel