10000 MAINT Adds sphinx configuration for redirections by thomasjpfan · Pull Request #20625 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MAINT Adds sphinx configuration for redirections #20625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

thomasjpfan
Copy link
Member
@thomasjpfan thomasjpfan commented Jul 28, 2021

Reference Issues/PRs

Follow up to #20624

What does this implement/fix? Explain your changes.

With #20624 we have an empty example:

Screen Shot 2021-07-28 at 9 35 09 AM

This PR adds a mechanism for doing any redirect in sphinx.

Any other comments?

CC @glemaitre @ogrisel

@thomasjpfan thomasjpfan mentioned this pull request Jul 28, 2021
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it does what we would like :)
LGTM

@GaelVaroquaux
Copy link
Member

Great! Solution! Let's check that it renders well and then merge.

Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this works but it works great!

<title>scikit-learn: machine learning in Python</title>
</head>
<body>
<p>You will be automatically redirected to the <a href="{{ pathto('index') }}">main page</a>.</p>
<p>You will be automatically redirected to the <a href="{{ redirect }}">main page</a>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>You will be automatically redirected to the <a href="{{ redirect }}">main page</a>.</p>
<p>You will be automatically redirected to the <a href="{{ redirect }}">new location of this page</a>.</p>

@glemaitre glemaitre merged commit 01a28e9 into scikit-learn:main Jul 28, 2021
@glemaitre
Copy link
Member

Nice. Thanks @thomasjpfan

TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Jul 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0