[WIP] FIX index overflow error in sparse matrix polynomial expansion … #20524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @niuk-a I'm sorry your pull request got lost. If you are still interested in working on this do you mind synchronizing with upstream/main? Thanks for your patience and your work so far. |
Contributor
|
@niuk-a Just wanted to see if you were still working on this PR |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19676
Fixes #17554
What does this implement/fix? Explain your changes.
The _csr_polynomial_expansion function in sklearn.preprocessing.PolynomialFeatures now can work with int64 index
What was done:
All necessary resulting data arrays now allocated in python part outside of _csr_polynomial_expansion
The type of the resulting data array now depends on expanded_d
cc: (reviewer) @wdevazelhes , @thomasjpfan