8000 [WIP] FIX index overflow error in sparse matrix polynomial expansion … by niuk-a · Pull Request #20524 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[WIP] FIX index overflow error in sparse matrix polynomial expansion … #20524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] FIX index overflow error in sparse matrix polynomial expansion … #20524

wants to merge 1 commit into from

Conversation

niuk-a
Copy link
Contributor
@niuk-a niuk-a commented Jul 13, 2021 •
edited
Loading

Reference Issues/PRs

Fixes #19676
Fixes #17554

What does this implement/fix? Explain your changes.

The _csr_polynomial_expansion function in 8000 sklearn.preprocessing.PolynomialFeatures now can work with int64 index

What was done:
All necessary resulting data arrays now allocated in python part outside of _csr_polynomial_expansion
The type of the resulting data array now depends on expanded_d

cc: (reviewer) @wdevazelhes , @thomasjpfan

@cmarmo
Copy link
Contributor
cmarmo commented Jan 24, 2022

Hi @niuk-a I'm sorry your pull request got lost. If you are still interested in working on this do you mind synchronizing with upstream/main? Thanks for your patience and your work so far.

@Micky774
Copy link
Contributor

@niuk-a Just wanted to see if you were still working on this PR

@Micky774 Micky774 mentioned this pull request Jun 22, 2022
Merged
@cmarmo cmarmo added Superseded PR has been replace by a newer PR and removed Waiting for Reviewer labels Jul 9, 2022
@cmarmo
Copy link
Contributor
cmarmo commented Jul 9, 2022

Closing as superseded by #23731. Thanks @niuk-a for your work!

@cmarmo cmarmo closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cython module:preprocessing Superseded PR has been replace by a newer PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cython code for PolynomialFeatures should use int64s for indices.
3 participants
@niuk-a @cmarmo @Micky774
0