-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
MAINT Improve source generation using Tempita
#20481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glemaitre
merged 42 commits into
scikit-learn:main
from
mbatoul:migrate_weightvector_to_use_tempita
Aug 9, 2021
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
930e27d
[skip ci] Trigger PR
f40dcca
Move weith_vector to a template
c158a79
transform weight_vector.pxd.tp into a template
d1139a1
move pyx into pyx.tp
ef6ca46
first pass in changing doubles
04ce5c9
change all double that were missing
50de266
fix compilation
33daf18
Merge branch 'main' into migrate_weightvector_to_use_tempita
mbatoul de16964
Merge branch 'main' into migrate_weightvector_to_use_tempita
mbatoul 3a05e42
Add newlines to template files.
mbatoul f8bd689
Git-ignore `.pyx` and `.pxd` files generated by Tempita from `weight_…
mbatoul 41d9a0d
Remove `get_dispatch` unnecessary function and iterate directly over …
mbatoul c383712
Test that files generated by templates are git-ignored.
mbatoul c6625c0
Add `_sag_fast` templates to `setup.py` + git-ignore the generated fi…
mbatoul 1bc6be8
Read `.gitignore` file content and check files generated by Tempita t…
mbatoul c05767b
Set `w` and `aw` attributes as `readonly`.
mbatoul 1cc06e5
Merge branch 'main' into migrate_weightvector_to_use_tempita
mbatoul bedf4cf
Add test for type invariance for `WeightVector` interface.
mbatoul bf76657
Remove unnecessary file from `gitignore`.
mbatoul df6e549
Move lines of code to reduce diff.
mbatoul 77fa382
Remove outdated argument of `gen_from_templates` function.
mbatoul d772d43
Parametrize `test_type_invariance`.
mbatoul 9456ba3
Add test for source files generation from templates.
mbatoul 9a64435
Remove `sklearn/linear_model/_sag_fast.pyx.tp` from `sklearn/utils/se…
mbatoul d39edd1
Remove duplicated `cdef` declaration in `WeightVector` class.
mbatoul da946c6
Remove `cython: language_level=3` from `weight_vector` template files.
mbatoul ea2470b
Remove useless constant variable in `test_cython_templating`.
mbatoul fc8a32d
Remove unused import.
mbatoul 2794c77
Fix `test_files_generated_by_templates_are_git_ignored`.
mbatoul 9452515
Revert "Add test for source files generation from templates."
mbatoul 0d2af89
Remove top file author.
mbatoul 68282be
Use typed-memoryview for `WeightVector` interface.
mbatoul 1043fa0
Pass class name argument to parametrize`test_weight_vector`.
mbatoul 1ad9ae3
Add comment to `test_cython_templating`.
mbatoul a8d7cf9
Add type to epsilon for comparison in `WeightVector#scale`.
mbatoul ac35302
Remove whitespaces.
mbatoul 0f4b057
Rename Tempita variable `name` as `name_suffix` in `.tp` files.
mbatoul 393f835
Set `reset_wscale_threshold` at `1e-6` for float32 and `1e-09` for fl…
mbatoul 3c56e7c
Update `setup.cfg` file.
mbatoul d52c676
Keep alphanumerical order of files in `setup.cfg`.
mbatoul 033f3f4
Stop storing `reset_wscale_threshold` in a variable.
mbatoul 6abf315
Improve docstrings.
mbatoul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.