8000 MAINT Make multioutput tests deterministic by ogrisel · Pull Request #20468 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MAINT Make multioutput tests deterministic #20468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

MAINT Make multioutput tests deterministic #20468

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9cc9fd
Make multioutput tests deterministic
ogrisel Jul 5, 2021
c009f8d
DEBUG: try test_multi_target_regression with 1000 seeds [cd build]
ogrisel Jul 5, 2021
473c329
Revert "DEBUG: try test_multi_target_regression with 1000 seeds [cd b…
ogrisel Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sklearn/tests/test_multioutput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@


def test_multi_target_regression():
X, y = datasets.make_regression(n_targets=3)
X, y = datasets.make_regression(n_targets=3, random_state=0)
X_train, y_train = X[:50], y[:50]
X_test, y_test = X[50:], y[50:]

Expand All @@ -52,7 +52,7 @@ def test_multi_target_regression():


def test_multi_target_regression_partial_fit():
X, y = datasets.make_regression(n_targets=3)
X, y = datasets.make_regression(n_targets=3, random_state=0)
X_train, y_train = X[:50], y[:50]
X_test, y_test = X[50:], y[50:]

Expand All @@ -76,15 +76,15 @@ def test_multi_target_regression_partial_fit():

def test_multi_target_regression_one_target():
# Test multi target regression raises
X, y = datasets.make_regression(n_targets=1)
X, y = datasets.make_regression(n_targets=1, random_state=0)
rgr = MultiOutputRegressor(GradientBoostingRegressor(random_state=0))
msg = "at least two dimensions"
with pytest.raises(ValueError, match=msg):
rgr.fit(X, y)


def test_multi_target_sparse_regression():
X, y = datasets.make_regression(n_targets=3)
X, y = datasets.make_regression(n_targets=3, random_state=0)
X_train, y_train = X[:50], y[:50]
X_test = X[50:]

Expand Down Expand Up @@ -601,7 +601,7 @@ def fit(self, X, y, sample_weight=None, **fit_params):
),
(
MultiOutputRegressor(DummyRegressorWithFitParams()),
datasets.make_regression(n_targets=3),
datasets.make_regression(n_targets=3, random_state=0),
),
],
)
Expand All @@ -616,7 +616,7 @@ def test_multioutput_estimator_with_fit_params(estimator, dataset):
def test_regressor_chain_w_fit_params():
# Make sure fit_params are properly propagated to the sub-estimators
rng = np.random.RandomState(0)
X, y = datasets.make_regression(n_targets=3)
X, y = datasets.make_regression(n_targets=3, random_state=0)
weight = rng.rand(y.shape[0])

class MySGD(SGDRegressor):
Expand Down
0