8000 DOC Ensures that BaggingClassifier passes numpydoc validation #20377 by jbsilva · Pull Request #20407 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Ensures that BaggingClassifier passes numpydoc validation #20377 #20407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 29, 2021
Merged

DOC Ensures that BaggingClassifier passes numpydoc validation #20377 #20407

merged 7 commits into from
Jun 29, 2021

Conversation

jbsilva
Copy link
Contributor
@jbsilva jbsilva commented Jun 26, 2021 •
edited
Loading

Reference Issues/PRs

Addresses #20308.

What does this implement/fix? Explain your changes.

This PR ensures BaggingClassifier is compatible with numpydoc.

  • Remove BaggingClassifier from DOCSTRING_IGNORE_LIST.
  • Verify all tests passing.

Any other comments?

Thanks #DataUmbrella for the 2021 Latin America scikit-learn open source #sprint.

@thomasjpfan thomasjpfan mentioned this pull request Jun 27, 2021
Closed
@reshamas
Copy link
Member

Updating with correct spelling: #DataUmbrella sprint

@ogrisel
Copy link
Member
ogrisel commented Jun 28, 2021

I merged the main branch to check whether the merge of #20410 will fix the new sphinx warnings or if there are other similar warnings to fix.

ogrisel
ogrisel approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the sphinx warnings are fixed by the above merge, the PR itself looks good to me.

@ogrisel ogrisel merged commit 04edd21 into scikit-learn:main Jun 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@jbsilva @ogrisel @samronsin
DOC Ensures that BaggingClassifier passes numpydoc validation scikit-…
1605b40 
…learn#20377 (scikit-learn#20407)


Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Documentation module:ensemble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbsilva @reshamas @ogrisel
0