8000 DOC Ensures that RandomForestRegressor passes numpydoc validation by alinealfa · Pull Request #20401 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Ensures that RandomForestRegressor passes numpydoc validation #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

DOC Ensures that RandomForestRegressor passes numpydoc validation #20401

merged 3 commits into from
Jun 29, 2021

Conversation

alinealfa
Copy link
Contributor

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Fixes numpydoc errors on RandomForestRegressor

Any other comments?

Compare #20383
#DataUmbrella #sprint
cc. @marenwestermann

@ogrisel
Copy link
Member
ogrisel commented Jun 28, 2021 •
edited
Loading

@alinealfa thanks for the contribution. Unfortunately there was a change to the same file that was concurrent merged in the main branch. Would you please merge upstream/main into your branch, resolve the conflict and push the result to your PR?

git fetch upstream main
git merge upstream/main
git status  # to see which files have a problem
# edit files with conflict markers
git add path/to/file_with_fixes
git commit
git push

glemaitre
glemaitre reviewed Jun 28, 2021
View reviewed changes
sklearn/ensemble/_forest.py
@@ -615,6 +615,13 @@ def feature_importances_(self):
)
@property
def n_features_(self):
"""Number of features when fitting the estimator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open #20414 to check the issue with sphinx and as well to discuss property formatting. We can wait to see how do we want to format property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no problem with docstring.

ogrisel
ogrisel approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @alinealfa!

8000
@ogrisel ogrisel merged commit 427d696 into scikit-learn:main Jun 29, 2021
@alinealfa
Copy link
Contributor Author

Thanks @ogrisel. I was waiting for discussion on #20383 to get a final version compatible with back, numpydoc and sphinx.

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@alinealfa @ogrisel @samronsin
DOC Ensures that RandomForestRegressor passes numpydoc validation (sc…
ab13640 
…ikit-learn#20401)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:ensemble No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinealfa @ogrisel @glemaitre @thomasjpfan
0