8000 FIX deprecated properties correctly wraps the property's docstring by thomasjpfan · Pull Request #20385 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX deprecated properties correctly wraps the property's docstring #20385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2021
Merged

FIX deprecated properties correctly wraps the property's docstring #20385

merged 2 commits into from
Jun 26, 2021

Conversation

thomasjpfan
Copy link
Member

Related to #20308

CC @amueller

@amueller
Copy link
Member

@glemaitre wanna give this a look to unblock some of the sprinters?

glemaitre
glemaitre approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Not easy to get decorator right :)

@glemaitre
Copy link
Member

I will just wait to have one CI to pass to be sure that we don't miss something :)

@glemaitre glemaitre mentioned this pull request Jun 26, 2021
Merged
@glemaitre glemaitre merged commit 1abc3f2 into scikit-learn:main Jun 26, 2021
@glemaitre
Copy link
Member

pylatest passed so we should be good to go.

@thomasjpfan thomasjpfan mentioned this pull request Jun 27, 2021
Merged
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@thomasjpfan @samronsin
FIX deprecated properties correctly wraps the property's docstring (s…
cad1277 
…cikit-learn#20385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @amueller @glemaitre
0