10000 DOC Fixes numpydoc validation errors in KNeighborsClassifier by pibieta · Pull Request #20373 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@pibieta
Copy link
Contributor
@pibieta pibieta commented Jun 26, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

Fixes numpydoc validation errors in KNeighborsClassifier, namely:

  • Missing See Also descriptions.
  • Added periods.
  • Capital letter at the beginning of descriptions.

Any other comments?

#DataUmbrella sprint
cc: @pibieta @g4brielvs

@amueller
Copy link
Member

I think there's a linting issue with a line being too long, I think it might be whitespace?

Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let see if the CIs agree ;)

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @pibieta !

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@pibieta
Copy link
Contributor Author
pibieta commented Jun 26, 2021

It seems I need an approval for github to run the test on 2 worlkflows. Can you help with that @glemaitre ?

@glemaitre glemaitre merged commit 03ab582 into scikit-learn:main Jun 28, 2021
@glemaitre
Copy link
Member

Looks good. Merging. Thanks @pibieta

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…learn#20373)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0