8000 Update _scorer.py by helper-uttam · Pull Request #20316 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Update _scorer.py #20316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update _scorer.py #20316

wants to merge 1 commit into from

Conversation

helper-uttam
Copy link
Contributor

Updating Root mean squared log error

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@helper-uttam
Update _scorer.py
5294438 
Updating Root mean squared log error
@rth rth mentioned this pull request Jun 21, 2021
Closed
@rth
Copy link
Member
rth commented Jun 21, 2021

Thanks for your contribution and welcome @helper-uttam !

The first step for adding a new feature to scikit-learn is to open an issue to ask if it's something that could be added, and get approval from a member of the core team before starting the implementation. In particular it would be helpful to explain why this metric is something that would be useful.

You would also need to be patient, it can take days to get a response, because there are many issues/PRs and few people able to review them. Don't hesitate to contribute on other open issues (see tags "Good first issue" and "help wanted").

@helper-uttam
Copy link
Contributor Author

@rth Thankyou so much for your time!
I will do the same as you guided. But should I close this PR or let it be open?

Thankyou again! :)

@rth
Copy link
Member
rth commented Jun 21, 2021

You can keep it open I think.

@helper-uttam helper-uttam mentioned this pull request Jun 21, 2021
Closed
@helper-uttam
Copy link
Contributor Author

@rth sure!
I had opened a new issue regarding the same :)

@helper-uttam
Copy link
Contributor Author

Hi, I had closed this PR and opened a new one i.e, #20322

please check it if I had done anything wrong.

Thankyou for you guidance, your guidance helped me a lot @rth !

@ogrisel ogrisel mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helper-uttam @rth
0