8000 MNT deprecate n_input_features_ in PolynomialFeatures by jeremiedbb · Pull Request #20240 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT deprecate n_input_features_ in PolynomialFeatures #20240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 11, 2021
Merged

MNT deprecate n_input_features_ in PolynomialFeatures #20240

merged 9 commits into from
Jun 11, 2021

Conversation

jeremiedbb
Copy link
Member

in favor of n_features_in_ (see #19333)

cc @glemaitre

glemaitre
glemaitre approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only need a small note in what's new to use or refer to n_features_in_.

lorentzenchr
lorentzenchr approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

glemaitre
glemaitre reviewed Jun 10, 2021
View reviewed changes
@glemaitre
Copy link
Member

The azure failure is only due to openml

ogrisel
ogrisel approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel merged commit 28bc843 into scikit-learn:main Jun 11, 2021
@lorentzenchr lorentzenchr mentioned this pull request Jun 12, 2021
Closed
47 tasks
@eddiebergman eddiebergman mentioned this pull request Nov 15, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@ogrisel ogrisel ogrisel approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremiedbb @glemaitre @ogrisel @lorentzenchr
0