8000 KBinsDiscretizer efficiency improvement to 'kmeans' strategy by glevv · Pull Request #19934 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

KBinsDiscretizer efficiency improvement to 'kmeans' strategy #19934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2021
Merged

KBinsDiscretizer efficiency improvement to 'kmeans' strategy #19934

merged 4 commits into from
Apr 20, 2021

Conversation

glevv
Copy link
Contributor
@glevv glevv commented Apr 20, 2021

Reference Issues/PRs

Fixes #19256 - Change KMeans algorithm in KBinsDiscretizer from 'auto' (elkan) to 'full'

jeremiedbb
jeremiedbb approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glevv !

TomDLT
TomDLT reviewed Apr 20, 2021
View reviewed changes
Copy link
Member
@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change of algorithm only changing speed, or is it also going to change the clustering results ?

@jeremiedbb
Copy link
Member

only the speed

GaelVaroquaux
GaelVaroquaux approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member
@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The benchmarks are in the issue referenced in the description. Merging. Thanks!

@GaelVaroquaux GaelVaroquaux merged commit 7ddd6e5 into scikit-learn:main Apr 20, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
@jeremiedbb jeremiedbb mentioned this pull request Jul 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@TomDLT TomDLT TomDLT approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change KMeans algorithm for KBinsDiscretizer from 'elkan' (default) to 'full'
4 participants
@glevv @jeremiedbb @GaelVaroquaux @TomDLT
0