8000 ENH Adds n_features_in_ to naive_bayes by lorentzenchr · Pull Request #19485 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Adds n_features_in_ to naive_bayes #19485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

ENH Adds n_features_in_ to naive_bayes #19485

merged 3 commits into from
Feb 23, 2021

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Continues #18514 and #19333.

@lorentzenchr lorentzenchr mentioned this pull request Feb 18, 2021
Closed
47 tasks
thomasjpfan
thomasjpfan approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

thomasjpfan
thomasjpfan approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ogrisel
ogrisel approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@ogrisel ogrisel merged commit 5c24622 into scikit-learn:main Feb 23, 2021
@lorentzenchr lorentzenchr deleted the n_features_naive branch February 23, 2021 18:04
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:naive_bayes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @ogrisel @thomasjpfan
0