8000 TST replace assert_warns* by pytest.warns in model_selection/tests by nuka137 · Pull Request #19458 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST replace assert_warns* by pytest.warns in model_selection/tests #19458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2021
Merged

TST replace assert_warns* by pytest.warns in model_selection/tests #19458

merged 4 commits into from
Feb 19, 2021

Conversation

nuka137
Copy link
Contributor
@nuka137 nuka137 commented Feb 15, 2021

Reference Issues/PRs

#19414

What does this implement/fix? Explain your changes.

Remove the use of assert_warns and assert_warns_message from tests in model_selection/tests.

Any other comments?

The PR is for the part of #19414

ogrisel
ogrisel approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions but other than that: LGTM.

nuka137 and others added 2 commits February 17, 2021 07:18
@nuka137 @ogrisel
Apply suggestion code
29ba69f 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@nuka137
Address requests from the review
b906fdc
jeremiedbb
jeremiedbb approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The linting issue should be fixed by the suggestion below

@nuka137 @jeremiedbb
Apply suggestion code
8e0e4c5 
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@jeremiedbb jeremiedbb merged commit b5e55f7 into scikit-learn:main Feb 19, 2021
@jeremiedbb
Copy link
Member

Thanks @nuka137 !

@nuka137 nuka137 deleted the remove-assert-warn-from-model-selection-tests branch February 19, 2021 12:13
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuka137 @jeremiedbb @ogrisel
0