8000 ENH Adds categories with missing values support to fetch_openml with as_frame=True by amy12xx · Pull Request #19365 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Adds categories with missing values support to fetch_openml with as_frame=True #19365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 6, 2021
Merged

ENH Adds categories with missing values support to fetch_openml with as_frame=True #19365

merged 10 commits into from
Feb 6, 2021

Conversation

amy12xx
Copy link
Contributor
@amy12xx amy12xx commented Feb 6, 2021 •
edited by glemaitre
Loading

Fixes #18383
Supersedes #18383

Enables using the categorical dtype for features with missing values.

glemaitre
glemaitre reviewed Feb 6, 2021
View reviewed changes
@glemaitre glemaitre changed the title Openml pandas cat missing vals ENH Adds categories with missing values support to fetch_openml with as_frame=True Feb 6, 2021
glemaitre
glemaitre reviewed Feb 6, 2021
View reviewed changes
@glemaitre glemaitre self-requested a review February 6, 2021 08:10
glemaitre
glemaitre approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of those LGTM

@reshamas
Copy link
Member
reshamas commented Feb 6, 2021

#DataUmbrella sprint

glemaitre
glemaitre reviewed Feb 6, 2021
View reviewed changes
glemaitre
glemaitre approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@adrinjalali adrinjalali merged commit 80c47b0 into scikit-learn:main Feb 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@glemaitre glemaitre glemaitre approve 559F d these changes

Assignees
No one assigned
Labels
module:datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amy12xx @reshamas @adrinjalali @glemaitre @thomasjpfan
0