8000 ENH Adds n_features_in_ checking to feature_selection by thomasjpfan · Pull Request #19344 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

ENH Adds n_features_in_ checking to feature_selection #19344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2021
Merged

ENH Adds n_features_in_ checking to feature_selection #19344

merged 1 commit into from
Feb 8, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #19333

@thomasjpfan thomasjpfan mentioned this pull request Feb 4, 2021
Closed
47 tasks
@lorentzenchr
Copy link
Member

What to do with n_features_attribute in class RFE and class RFECV?

@glemaitre
Copy link
Member

What to do with n_features_attribute in class RFE and class RFECV?

We should probably deprecate it as well. It seems that we could make a follow-up for all estimators that were already storing this information.

glemaitre
glemaitre approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr
Copy link
Member

Separate PR for docstring and n_features_ attribute deprecation, now also tracked in #19333.

@lorentzenchr lorentzenchr merged commit 7e197fd into scikit-learn:main Feb 8, 2021
@thomasjpfan
Copy link
Member Author

The n_features_ attribute is the number of selected features, which would be different than n_features_in_.

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:feature_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @lorentzenchr @glemaitre
0