8000 CI Skips test in loading_other_datasets.rst based on env flag by thomasjpfan · Pull Request #19295 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Skips test in loading_other_datasets.rst based on env flag #19295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

CI Skips test in loading_other_datasets.rst based on env flag #19295

merged 1 commit into from
Feb 1, 2021

Conversation

thomasjpfan
Copy link
Member

This PR skips network tests in loading_other_datasets.rst when SKLEARN_SKIP_NETWORK_TESTS=1

ogrisel
ogrisel approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rth rth merged commit 4408a25 into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@thomasjpfan @glemaitre
CI Skips test in loading_other_datasets.rst based on env flag (scikit…
60555f8 
…-learn#19295)
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@thomasjpfan @glemaitre
CI Skips test in loading_other_datasets.rst based on env flag (#19295)
4fc65ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @rth
0