DOC fix ungrammatical sentence in doc of SelectFromModel #19240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jan 24, 2021
There was a problem hiding this comment.
Thanks @EdwinWenink, this is indeed clearer.
I noticed that the docstrinrg for estimator https://scikit-learn.org/stable/modules/generated/sklearn.feature_selection.SelectFromModel.html#sklearn.feature_selection.SelectFromModel
says
The estimator must have either a feature_importances_ or coef_ attribute after fitting.
This is actually not true anymore. Would you mind updating it to
The estimator should have a feature_importances_ or coef_ attribute after fitting. Otherwise, the
importance_getterparameter should be used.
Thanks!
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
|
@NicolasHug thanks for the quick reply. Good catch with the importance_getter, I hadn't noticed. I accepted your suggested change and also pushed your other recommendation. |
thomasjpfan
approved these changes
Jan 28, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
…n#19240) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
I noticed an ungrammatical sentence in the user documentation for
1.13.4. Feature selection using SelectFromModel. This is a small commit with a proposed improvement that should capture the intended meaning of the sentence.Any other comments?