8000 DOC fix ungrammatical sentence in doc of SelectFromModel by EdwinWenink · Pull Request #19240 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC fix ungrammatical sentence in doc of SelectFromModel #19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

EdwinWenink
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

I noticed an ungrammatical sentence in the user documentation for 1.13.4. Feature selection using SelectFromModel. This is a small commit with a proposed improvement that should capture the intended meaning of the sentence.

Any other comments?

Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EdwinWenink, this is indeed clearer.

I noticed that the docstrinrg for estimator https://scikit-learn.org/stable/modules/generated/sklearn.feature_selection.SelectFromModel.html#sklearn.feature_selection.SelectFromModel
says

The estimator must have either a feature_importances_ or coef_ attribute after fitting.

This is actually not true anymore. Would you mind updating it to

The estimator should have a feature_importances_ or coef_ attribute after fitting. Otherwise, the importance_getter parameter should be used.

Thanks!

@EdwinWenink
Copy link
Contributor Author

@NicolasHug thanks for the quick reply. Good catch with the importance_getter, I hadn't noticed. I accepted your suggested change and also pushed your other recommendation.

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @EdwinWenink !

LGTM

@thomasjpfan thomasjpfan changed the title [DOC] fix ungrammatical sentence in doc of SelectFromModel DOC fix ungrammatical sentence in doc of SelectFromModel Jan 28, 2021
Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EdwinWenink!

@rth rth merged commit 0cc91e7 into scikit-learn:main Feb 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0