8000 MNT remove documentation doctest in pypy build by glemaitre · Pull Request #19057 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MNT remove documentation doctest in pypy build #19057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented Dec 22, 2020

Remove the doctest check in pypy

@glemaitre glemaitre changed the title MNT remove docstring check in pypy build MNT remove documentation doctest in pypy build Dec 22, 2020
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merge when green.

@ogrisel
Copy link
Member
ogrisel commented Dec 22, 2020

For context, this is to avoid spurious failures related to numeric formatting such as:

https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/10378/workflows/8ef033bb-37ac-487c-a06b-f9439c0d4c2b/jobs/128307

We do not care about those formatting variations in the documentation outputs. The code snippets in the example are alreay covered in the CPython CI jobs.

It's actually not running PyPy as part of the PR CI, so let's merge.

@ogrisel ogrisel merged commit afbd4b3 into scikit-learn:master Dec 22, 2020
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0