8000 CI Use Travis secret tokens to upload the ARM64 wheels by alfaro96 · Pull Request #19017 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Use Travis secret tokens to upload the ARM64 wheels #19017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2020
Merged

CI Use Travis secret tokens to upload the ARM64 wheels #19017

merged 3 commits into from
Dec 22, 2020

Conversation

alfaro96
Copy link
Member
@alfaro96 alfaro96 commented Dec 16, 2020 •
edited
Loading

Reference Issues/PRs

See #18782 (comment).

What does this implement/fix? Explain your changes.

This PR uses the Travis secret tokens to upload the ARM64 wheels to Anaconda cloud.

Any other comments?

I have used the same approach that the numpy wheel builder.

CC @thomasjpfan and @ogrisel.

@alfaro96 alfaro96 requested a review from ogrisel December 16, 2020 11:33
@alfaro96 alfaro96 added Build / CI To backport PR merged in master that need a backport to a release branch defined based on the milestone. labels Dec 16, 2020
@alfaro96 alfaro96 changed the title CD Use Travis secret tokens to upload the wheels CD Use Travis secret tokens to upload the ARM64 wheels Dec 16, 2020
@alfaro96 alfaro96 changed the title CD Use Travis secret tokens to upload the ARM64 wheels CD Remove unnecessary environment variables from .travis.yml Dec 16, 2020
@alfaro96 alfaro96 changed the title CD Remove unnecessary environment variables from .travis.yml CD Use Travis secret tokens to upload the ARM64 wheels Dec 16, 2020
@alfaro96
Copy link
Member Author

Not sure but maybe it is better to use $TRAVIS_BRANCH == master instead of $TRAVIS_EVENT_TYPE == cron for uploading to Anaconda nightly.

WDYT?

@alfaro96 alfaro96 added this to the 0.24 milestone Dec 16, 2020< 8000 /a>
@alfaro96 alfaro96 mentioned this pull request Dec 17, 2020
Closed
@thomasjpfan
Copy link
Member

Not sure but maybe it is better to use $TRAVIS_BRANCH == master instead of $TRAVIS_EVENT_TYPE == cron for uploading to Anaconda nightly.

I think cron is correct in this context as it is the nightly wheel.

thomasjpfan
thomasjpfan approved these changes Dec 17, 2020
View reviewed changes
@alfaro96 alfaro96 changed the title CD Use Travis secret tokens to upload the ARM64 wheels CI Use Travis secret tokens to upload the ARM64 wheels Dec 22, 2020
ogrisel
ogrisel approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I defined the SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKEN and SCIKIT_LEARN_STAGING_UPLOAD_TOKEN in the travis-ci.com/scikit-learn/scikit-learn settings.

They are only available on builds that run for the main repo, not builds triggered by PR from github forks.

@ogrisel ogrisel merged commit 3e73679 into scikit-learn:master Dec 22, 2020
@ogrisel
Copy link
Member
ogrisel commented Dec 22, 2020

Forgot to add [cd build] to the commit message to test it :( . Will push an empty commit directly on master.

ogrisel added a commit that referenced this pull request Dec 22, 2020
@ogrisel
Trigger [cd build] to test the result of #19017
7a1aad0
@ogrisel
Copy link
Member
ogrisel commented Dec 22, 2020

The travis build on master is happening here: https://github.com/scikit-learn/scikit-learn/runs/1594416532 (fingers crossed).

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@alfaro96 @glemaitre
CI Use Travis secret tokens to upload the ARM64 wheels (scikit-learn#…
60feab1 
…19017)
@ogrisel
Copy link
Member
ogrisel commented Dec 22, 2020 •
edited
Loading

The Linux aarch64 wheels are online: https://anaconda.org/scikit-learn-wheels-staging/scikit-learn/files \o/

@alfaro96 alfaro96 deleted the remove_token branch December 22, 2020 14:04
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@alfaro96 @glemaitre
CI Use Travis secret tokens to upload the ARM64 wheels (scikit-learn#…
3aa728d 
…19017)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@ogrisel @glemaitre
Trigger [cd build] to test the result of scikit-learn#19017
d9b359c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
0.24
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @thomasjpfan @ogrisel
0