8000 Fix pull request template link by harrismirza · Pull Request #19009 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Fix pull request template link #19009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

harrismirza
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This removes the '#pull-request-checklist' anchor tag from the url to the contribution guidelines, that section doesn't exist.

Any other comments?

Corrected the docs for balanced_accuracy_score
Removed non-existent anchor from link to Contributing guide
@@ -1787,7 +1787,7 @@ def balanced_accuracy_score(y_true, y_pred, *, sample_weight=None,
deal with imbalanced datasets. It is defined as the average of recall
obtained on each class.

The best value is 1 and the worst value is 0 when ``adjusted=False``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I accidentally started off the wrong branch, I'll correct this now

@glemaitre glemaitre merged commit a28da97 into scikit-learn:master Dec 15, 2020
@glemaitre
Copy link
Member

Thanks @harrismirza

@glemaitre glemaitre mentioned this pull request Dec 22, 2020
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0