MNT change 0.25 to 1.0 and 0.26 to 1.1 in deprecation messages #19005
Conversation
|
Should we write "1.0 (renaming of 0.25)" and "1.1 (renaming of 0.26)" for the continuity to be clear? Usually, messages are the form "deprecated in version x and will be removed in version x+2" and that "+2" part is lost now, so unless people are aware that 1.0 == 0.25, they'll have no idea when the deprecation will be final. |
|
We can do that for 0.25 since we already issued the warning in the previous release. For the 0.26, we never issued the warning do you think that this is indeed necessary? |
I like this suggestion. |
|
Yes I think it's still relevant for 0.26/1.1 because "this is deprecated in 0.24 and will be removed in 1.1" says nothing about what 1.1 is w.r.t. 0.24, or when 1.1 will be released |
There was a problem hiding this comment.
Thanks for working on this @glemaitre , LGTM
Maybe this is something we can merge with just 1 approval if we need to move things forward, so I'd say feel free to self-merge
I would not be against this. This is mechanical procedure. |
doc/developers/develop.rst
Outdated
| The _pairwise attribute is deprecated in 0.24. From 1.1 onward | ||
| (renaming of 0.26), the `pairwise` estimator tag should be used instead. |
There was a problem hiding this comment.
| The _pairwise attribute is deprecated in 0.24. From 1.1 onward | |
| (renaming of 0.26), the `pairwise` estimator tag should be used instead. | |
| The _pairwise attribute is deprecated in 0.24. From 1.1 (renaming of 0.26) | |
| onward, the `pairwise` estimator tag should be used instead. |
There was a problem hiding this comment.
I a bit confused, is it the opposit of what Nicolas wanted or that you proposed the same change?
|
Yep let's go :)
…On Fri, 18 Dec 2020 at 17:08, Nicolas Hug ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/developers/develop.rst
<#19005 (comment)>
:
> + The _pairwise attribute is deprecated in 0.24. From 1.1 onward
+ (renaming of 0.26), the `pairwise` estimator tag should be used instead.
It's NBD, merging ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19005 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P4AUVSX2QZU4E3G75LSVN5A3ANCNFSM4U4B5UXA>
.
--
Guillaume Lemaitre
Scikit-learn @ Inria Foundation
https://glemaitre.github.io/
|
…t-learn#19005) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…t-learn#19005) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Change the version in
FutureWarningafter making the choice of releasing a major upcoming release (1.0)