8000 DOC explain how to use custom edge bins in KBinsDiscretizer by Todaime · Pull Request #18972 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC explain how to use custom edge bins in KBinsDiscretizer #18972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 15, 2020
Merged

DOC explain how to use custom edge bins in KBinsDiscretizer #18972

merged 15 commits into from
Dec 15, 2020

Conversation

Todaime
Copy link
Contributor
@Todaime Todaime commented Dec 6, 2020 •
edited
Loading

Fixes #18498

What does this implement/fix? Explain your changes.

This add documentation about how to use the FunctionTransformer and panda.cut function in order to provide custom edge bins.

@Todaime Todaime changed the title Doc kbins discretizer Documentation on how to use custom edge bins, KBinsDiscretizer Dec 6, 2020
glemaitre
glemaitre reviewed Dec 15, 2020
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would reword slightly the proposal.

@glemaitre glemaitre changed the title Documentation on how to use custom edge bins, KBinsDiscretizer DOC explain how to use custom edge bins in KBinsDiscretizer Dec 15, 2020
Maxime Prieur and others added 4 commits December 15, 2020 18:19
@glemaitre
Update doc/modules/preprocessing.rst
e2da3ee 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Update doc/modules/preprocessing.rst
28ac063 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Update doc/modules/preprocessing.rst
5885066 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
Update doc/modules/preprocessing.rst
001b5fe 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Todaime
Todaime commented Dec 15, 2020
View reviewed changes
Copy link
Contributor Author
@Todaime Todaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commited your changes! ;)

@Todaime Todaime requested a review from glemaitre December 15, 2020 18:47
@glemaitre glemaitre merged commit 58f9143 into scikit-learn:master Dec 15, 2020
@glemaitre
Copy link
Member

Thanks @Todaime

@glemaitre glemaitre mentioned this pull request Dec 15, 2020
Closed
@Todaime Todaime deleted the doc_KbinsDiscretizer branch December 15, 2020 20:45
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@glemaitre
DOC explain how to use custom edge bins in KBinsDiscretizer (scikit-l…
0820b41 
…earn#18972)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
856F
12 tasks
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@glemaitre
DOC explain how to use custom edge bins in KBinsDiscretizer (scikit-l…
fb1c096 
…earn#18972)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre Awaiting requested review from glemaitre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document on how to use custom bin edges in KBinsDiscretizer
2 participants
@Todaime @glemaitre
0