8000 CI Dynamically select unpack directory by alfaro96 · Pull Request #18957 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Dynamically select unpack directory #18957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 2, 2020
Merged

CI Dynamically select unpack directory #18957

merged 5 commits into from
Dec 2, 2020

Conversation

alfaro96
Copy link
Member
@alfaro96 alfaro96 commented Dec 2, 2020 •
edited
Loading

Reference Issues/PRs

#18956 (comment).

What does this implement/fix? Explain your changes.

This PR dynamically selects the destination directory for the unpacked wheel without needing the explicitly set an environment variable.

Any other comments?

Pinging @ogrisel and @cmarmo.

@alfaro96 alfaro96 requested a review from ogrisel December 2, 2020 13:59
ogrisel
ogrisel approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the macos builds to complete before merging just to be sure.

@alfaro96
Copy link
Member Author
alfaro96 commented Dec 2, 2020

Green :)

@ogrisel ogrisel merged commit 671069c into scikit-learn:master Dec 2, 2020
@alfaro96 alfaro96 deleted the dynamic_unpack_directory branch December 2, 2020 15:16
@ogrisel ogrisel mentioned this pull request Dec 2, 2020
Merged
12 tasks
@ogrisel
Copy link
Member
ogrisel commented Dec 2, 2020

Thanks for the fix @alfaro96 .

@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@alfaro96 @glemaitre
CI Dynamically select unpack directory (scikit-learn#18957)
2a46c04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfaro96 @ogrisel
0